KhronosGroup / Vulkan-ValidationLayers

Vulkan Validation Layers (VVL)
https://vulkan.lunarg.com/doc/sdk/latest/linux/khronos_validation_layer.html
Other
748 stars 400 forks source link

VUID-VkGraphicsPipelineCreateInfo-renderPass-06038 message improvement #8419

Closed ziga-lunarg closed 3 weeks ago

ziga-lunarg commented 4 weeks ago

The VUID message is: SPIR-V consumes input attachment index 4 but that is greater than the pSubpasses[0].inputAttachmentCount (4).

I think greater should be replaced with not less than

spencer-lunarg commented 3 weeks ago

... this is a common issue where we have something like

uint32_t something[4];

// accessing
something[4] = 0;

where it reads strange because the "index" was 4 and the size is 4

but I think going not less than is a smart way to word it