search

KhronosGroup / Vulkan-ValidationLayers

Vulkan Validation Layers (VVL)
https://vulkan.lunarg.com/doc/sdk/latest/linux/khronos_validation_layer.html
Other
751 stars 403 forks source link

gpuav: Handle VK_PIPELINE_LAYOUT_CREATE_INDEPENDENT_SETS_BIT_EXT #8630

Closed spencer-lunarg closed 2 days ago

spencer-lunarg commented 2 days ago

I missed this in https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/8565 and luckily there was a DebugPrintf test that caught this when I was merging things

The issue is based on having this

vkt::PipelineLayout pipeline_layout_vs(device, {&vertex_set.layout_, nullptr              }, {}, VK_PIPELINE_LAYOUT_CREATE_INDEPENDENT_SETS_BIT_EXT);
vkt::PipelineLayout pipeline_layout_fs(device, {nullptr,             &fragment_set.layout_}, {}, VK_PIPELINE_LAYOUT_CREATE_INDEPENDENT_SETS_BIT_EXT);
vkt::PipelineLayout pipeline_layout   (device, {&vertex_set.layout_, &fragment_set.layout_}, {},

and before we were grabbing the pipeline_layout_vs which ended up having a null set inside causing self validation error (and crashing on drivers as well in CI)

ci-tester-lunarg commented 2 days ago

CI Vulkan-ValidationLayers build queued with queue ID 269196.

ci-tester-lunarg commented 2 days ago

CI Vulkan-ValidationLayers build # 17647 running.

ci-tester-lunarg commented 2 days ago

CI Vulkan-ValidationLayers build # 17647 passed.