search

KhronosGroup / WebGL

The Official Khronos WebGL Repository
Other
2.66k stars 670 forks source link

Add a test for the creation of `RGBA16UI` textures with `UNPACK_PREMULTIPLY_ALPHA_WEBGL` enabled for chromium issue 40929470 #3660

Closed RandomGamingDev closed 4 months ago

RandomGamingDev commented 5 months ago

RGBA16UI textures, when created with UNPACK_PREMULTIPLY_ALPHA_WEBGL set to true result in the 1282 (GL_INVALID_OPERATION) error despite that being against standards and the same thing not happening on Firefox.

The issue has been reported and a PR/CL has been requested: Issue: https://issues.chromium.org/issues/40929470 PR/CL: https://chromium-review.googlesource.com/c/chromium/src/+/5525320

This PR is to add a test confirming that the issue's fix works and for future use.

There's also been an independent test made that this PR is based on: https://github.com/RandomGamingDev/Chrome-UNPACK_PREMULTIPLY_ALPHA_WEBGL-Failure-Demo

CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

RandomGamingDev commented 4 months ago

Requesting review from @kdashg and @kenrussell

kenrussell commented 4 months ago

Thanks for your contribution and sorry for the long delay reviewing this. Have just built your Chromium pull request locally and verified that your new test catches the earlier bug.