search

KhronosGroup / antora-ui-khronos

Default UI for Khronos Antora sites, forked 2023-03-12 from https://gitlab.com/antora/antora-ui-default at commit 41b1c83f648a656fcbb274a8003d7292ba4136b0
Mozilla Public License 2.0
5 stars 3 forks source link

Remove empty footer #12

Closed SaschaWillems closed 2 weeks ago

SaschaWillems commented 3 months ago

This PR removes (or better disables) the currently empty footer. That empty footer results in an odd way of scrolling past the end of a page's content and usability of the docs site is better without that footer.

See https://github.com/KhronosGroup/antora-ui-khronos/issues/13 (I can't seem to move that issue over here)

oddhack commented 2 weeks ago

LGTM. I don't think we need to stress overly about approving this, it is a purely editorial change.