search

KhronosGroup / glTF-Asset-Generator

Tool for generating various glTF assets for importer validation
MIT License
161 stars 42 forks source link

Add the Animation_SamplerType model group #534

Closed stevk closed 5 years ago

stevk commented 5 years ago

Test models for animation sampler component types. Animation_SamplerType

Fixes #533

stevk commented 5 years ago

@bghgary We'll need a updated npm babylonjs package with this fix before we can generate reference screenshots for these models.

bghgary commented 5 years ago

@lexaknyazev For normalized non-float quaternions, it's impossible to get a perfectly unit quaternion. The validator is giving errors for BYTE (though not for SHORT), but I don't think we can make it any closer. See https://github.com/KhronosGroup/glTF-Asset-Generator/blob/34047f054151b3ec7cb49e217da3c8e4d1c31ed3/Output/Positive/Animation_SamplerType/ValidatorResults/Animation_SamplerType_01.json#L10. Also, should implementations normalize quaternions when the type is normalized non-float?

lexaknyazev commented 5 years ago

For normalized non-float quaternions, it's impossible to get a perfectly unit quaternion

I think there was a proposal to adjust the validation threshold so that it allows the error from ubyte quaternions.