Fix crash when exporting animations with Full Collection Hierarchy option enabled.

KhronosGroup / glTF-Blender-IO

Blender glTF 2.0 importer and exporter

https://docs.blender.org/manual/en/latest/addons/import_export/scene_gltf2.html

Apache License 2.0

1.48k stars 316 forks source link

Fix crash when exporting animations with Full Collection Hierarchy option enabled. #2286

Closed sumihiro closed 1 month ago

sumihiro commented 1 month ago

Hi,

This pull request addresses an issue where the exporter crashes when attempting to export animations with the Full Collection Hierarchy option enabled.

Changes made:

Modified the animation caching logic to properly handle collections in the hierarchy
Ensured that collection objects are skipped in the object_caching function

This fix allows users to successfully export animations while using the Full Collection Hierarchy option without experiencing crashes.

Please review and let me know if any further changes or information are needed.

CLAassistant commented 1 month ago

All committers have signed the CLA.

julienduroure commented 1 month ago

Can you please confirm that you tested on 4.2, because this bug should already been solved between 4.1 and 4.2 Also, please provide a test .blend file that crash before your PR and not after your PR

sumihiro commented 1 month ago

I tested this on both 4.2 and the latest main branch, but it still crashed.

I'm attaching the blend file that causes the crash.

You can reproduce the crash by checking both 'Scene Graph > Full Collection Hierarchy' and 'Animation' options when exporting."

car.blend.zip

julienduroure commented 1 month ago

Hello, I can confirm the crash. I will go with my own implementation:

Early checks, avoiding checking hasattr for each object
Checks style more aligned with other part of the code ( checking vtree type instead of real Blender object type)

Thanks for pointing it out!

See #2287