search

KhronosGroup / glTF-CSharp-Loader

C# Reference Loader for glTF
Other
213 stars 60 forks source link

More Documentation #8

Closed realvictorprm closed 5 years ago

realvictorprm commented 6 years ago

I like this handy loader and would love to use it per default in my future projects. However during using it there came some simple questions up which would normally be in the documentation. Would be nice if you add some further documentation here on github :smiley:!

bghgary commented 6 years ago

Agreed. Documentation would be awesome. Contributions are welcome! 😄

realvictorprm commented 6 years ago

OK let's see what I can do here... I consider to rewrite parts of this in F# so I'll understand it anyways.

Also I must ask now the stupid question. How's loading images supposed? I noticed that I could use the byte offsets, however those aren't correct if I would load the whole file in (I've started working with glTF recently and only touched what it can do but not how to parse it :) )

bghgary commented 6 years ago

@vpenades just added a helper function.

https://github.com/KhronosGroup/glTF-CSharp-Loader/pull/7#issuecomment-328948498

Does that help?

realvictorprm commented 6 years ago

Ah you merged it, great!

Now I just need a build of this... Thanks Sir!

realvictorprm commented 6 years ago

Let me have another look into it in 8 hours, it's already midnight here haha :smile:

vpenades commented 6 years ago

I've created a pull request which documents the interface API.

bghgary commented 5 years ago

Closing this as we have documented the interface. We can re-open or open a more specific issue if there is a need.