search

KhronosGroup / glTF-Project-Explorer

Tool to provide a filterable registry of glTF community projects.
Apache License 2.0
87 stars 46 forks source link

F3D migration #130

Closed mwestphal closed 2 years ago

javagl commented 2 years ago

@weegeekps I had seen this PR and considered to ping you, but ... apparently, you know the answer to the question that I would have asked: "What is this?". (If it's not possible to provide enough context for me in one or two sentences, feel free to ignore that question...)

mwestphal commented 2 years ago

Looks like the question is not for me, in any case I should have added some context. I have added F3D to the list of application some time ago and we (f3d devs) migrated the repo and website, so I've just updated it. I hope thats okay. You can find more info about F3D here: https://f3d-app.github.io/f3d/

weegeekps commented 2 years ago

No worries. I noticed you had mentioned the PR in your own issue on your repo and figured since you appeared to be the lead contributor for F3D, the site you were switching to was valid, and the change seemed minimal, that no further discussion was required.

@javagl Should I have not merged this PR so willingly? Perhaps we need to come up with some ground rules in the event that a PR author doesn't include much context? In retrospect I realize I probably should have asked a question to the contributor.

javagl commented 2 years ago

Sorry, I could have derived the context from the linked f3d-app issue. Of course, in this case, it's perfectly fine to just merge it - no need to establish any other process: When a PR is obviously legitimate, every maintainer can just merge it.