KhronosGroup / glTF-Project-Explorer

Tool to provide a filterable registry of glTF community projects.
Apache License 2.0
87 stars 46 forks source link

Replaced simple Title search with indexed Title or Description search #139

Closed weegeekps closed 2 years ago

weegeekps commented 2 years ago

Resolves #119.

I replaced the simple Title search with a full index search using flexsearch. As of right now, I am only generating two indices: one for the title, and one for the description. The existing search field has been updated to use this new indexed search. I've also updated the label to reflect this change.

Below is a gif demonstrating the change.

2022-01-21 14 40 55

A few other things of note:

I will leave this PR open for a week and then plan on merging it after the Tooling TSG call on the 28th of January to give interested parties sufficient time to review.

javagl commented 2 years ago

Apologies for not providing any feedback via the review request of this and the other PR. I'll still try to allocate some time to have a closer look at the latest state (I might be able to do this during the weekend, depending on the progress with some other tasks).

weegeekps commented 2 years ago

@javagl No worries. I can always make changes after we merge it. I'll have another PR hopefully opened this week with some other enhancements.