Closed weegeekps closed 2 years ago
Apologies for not providing any feedback via the review request of this and the other PR. I'll still try to allocate some time to have a closer look at the latest state (I might be able to do this during the weekend, depending on the progress with some other tasks).
@javagl No worries. I can always make changes after we merge it. I'll have another PR hopefully opened this week with some other enhancements.
Resolves #119.
I replaced the simple Title search with a full index search using flexsearch. As of right now, I am only generating two indices: one for the title, and one for the description. The existing search field has been updated to use this new indexed search. I've also updated the label to reflect this change.
Below is a gif demonstrating the change.
A few other things of note:
name
(title) anddescription
fields are indexed. I have not included any indexing of fields we use for other filters. This is partially a performance decision, but also a UX one. When I was playing around with this, including the filter fields in the index was causing the query to return results that didn't seem relevant to the search.I will leave this PR open for a week and then plan on merging it after the Tooling TSG call on the 28th of January to give interested parties sufficient time to review.