search

KhronosGroup / glTF-Sample-Assets

To store all models and other assets related to glTF
255 stars 30 forks source link

Add dragon with dispersion #107

Closed emackey closed 3 months ago

emackey commented 4 months ago

This is the same dragon model with different settings and a different pattern on the background cloth, to highlight the effects of dispersion on the model.

echadwick-dgg3d commented 4 months ago

This looks great.

One potential issue is a discrepancy in attribution. The metadata.json and readme.md have different attributions than the glTF copyright section which says:

COPYRIGHT | CC-BY 4.0 Copyright 2023 Analytical Graphics, Inc. Model by Ed Mackey. Cloth backdrop CC0 by Adobe Inc.

Which is correct?

emackey commented 3 months ago

Thanks @echadwick-dgg3d. I fixed the copyright strings for both DragonDispersion and DragonAttenuation. Also I fixed the filename, which had the word "Test" in it even though the parent folder did not.

This is ready.