search

KhronosGroup / glTF-Sample-Assets

To store all models and other assets related to glTF
255 stars 30 forks source link

Fix "Box with Spaces" link issue #108

Closed emackey closed 1 month ago

emackey commented 4 months ago

@DRx3D Can you run the PHP script locally and check if this fixes #96 ?

emackey commented 1 month ago

This PR does not contain the correct fix for the issue. The PHP code itself needs to be modified to produce %20 for spaces in Markdown links, such as:

[Box With Spaces](./Box%20With%20Spaces/)

Note the label text can use real spaces, but the link target cannot contain a space.

It looks like one area of PHP code does contain a string-replace for %20 called $pathSafe or similar, but these safer paths are not used for Markdown link targets.