search

KhronosGroup / glTF-Sample-Assets

To store all models and other assets related to glTF
256 stars 30 forks source link

Folder and File Structure added #17

Closed echadwick-artist closed 8 months ago

echadwick-artist commented 11 months ago

Added a section with rules for folder structure and file names. Also fixed a few typos elsewhere in the doc.

echadwick-artist commented 11 months ago

There are a few possible points of contention which I would like feedback on.

  1. "PNG textures are preferred" ... This seems like it would make sense for the asset in the main /glTF subfolder, to avoid lossy errors in the main asset. But perhaps PNGs should belong in a "source assets" section instead, like used in the old glTF-Sample-Models repo?

  2. /glTF-JPG subfolder ... Do we want to specify this? Related to the above. If we use this naming convention then the StainedGlassLamp will need to have its subfolder renamed to suit.

  3. /glTF-IBL subfolder ... Do we want to include this? This is only used by one asset so far, https://github.com/KhronosGroup/glTF-Sample-Assets/tree/main/Models/EnvironmentTest which uses an extension that is not supported in the glTF Sample Viewer, but is supported in Babylon.js.

bghgary commented 11 months ago

3. /glTF-IBL subfolder ... Do we want to include this? This is only used by one asset so far, https://github.com/KhronosGroup/glTF-Sample-Assets/tree/main/Models/EnvironmentTest which uses an extension that is not supported in the glTF Sample Viewer, but is supported in Babylon.js.

I worked with @MiiBond to add this long ago, but given what we decided with this PR, maybe we shouldn't include any vendor extension assets (single or multi) in this repo?

DRx3D commented 8 months ago

@echadwick-artist , @bghgary : Does anything here require more discussion or approvals. It appears that the questions about folder names, PNG, and screenshot size are unanswered. Would those be better raised as issues?

echadwick-artist commented 8 months ago

OK I've moved this to an Issue, and I'm closing this PR.