Closed javagl closed 7 months ago
The scale
animations in this sample originally interpolated between (0.5, 0.5, 0.5) and (1.0, 1.0, 1.0). The sample now has been updated so that the scale
animations interpolate between (0.0, 0.0, 0.0) and (1.0, 1.0, 1.0).
The main purpose of this is that according to https://github.com/KhronosGroup/glTF-Sample-Assets/issues/77, a scale of (0,0,0) (with 'step' interpolation) is sometimes used to "completely hide" a mesh, and some viewer seemed to not handle this properly.
"Improve" is a very generic term, so here it is broken down:
The last one is the main reason for this update. This was brought up in https://github.com/KhronosGroup/glTF-Sample-Models/issues/391 , with some details described there. The animation data for the linear translations did not loop (i.e. they ended at a different place than where they started), and nearly all values (translations, rotations...) had been ... slightly odd numbers.
EDIT: The following is now obsolete. Apparently, the bug that caused the model to not be rendered in the sample viewer has been fixed - see https://github.com/KhronosGroup/glTF-Sample-Viewer/issues/495
Now... merging this should be uncontroversial, but... ... the updated model does not render in the glTF-Sample-Viewer 😬I opened https://github.com/KhronosGroup/glTF-Sample-Viewer/issues/495 to track this. Let's see how that plays out...