search

KhronosGroup / glTF-Sample-Assets

To store all models and other assets related to glTF
256 stars 30 forks source link

Builds are failing #27

Closed javagl closed 7 months ago

javagl commented 9 months ago

As mentioned in https://github.com/KhronosGroup/glTF-Sample-Assets/pull/24#issuecomment-1692400241 (and as it can be seen in the PR list), the builds are currently failing when a new model is added. I zoomed into that, a little bit, but ... am not a GitHub actions expert. So with the usual disclaimers (I have no idea what I'm doing here. LOL), a few comments:

Starting with an aside:

The workflows are run twice in the PR that I linked to above. This is probably related to the combination of

For example, in https://github.com/KhronosGroup/glTF-Sample-Assets/pull/26 , I'm creating a PR from a fork, and there, the workflows are only run once. Maybe there's a tricky way to avoid running them twice when the PR comes from KhronosGroup, but ... it shouldn't be so much an issue. (In fact, there sometimes seem to be difficulties when trying to run such actions based on PRs from a fork, but ... maybe we can make it work both ways).

The actual failing build:

Looking at the logs:

And it cannot commit with a deached head.

Now... why is the head detached here? I don't know. I haven't looked at the implementation of the actions/checkout@v2 action. From quickly skimming the documentation, it talks about a ref property that may determine what exactly is checked out, depending on what triggered the action. This might be related (or similar) to https://github.com/actions/checkout/issues/455.

I could reproduce the issue in my "Sandbox" repo (so apparently, ~"something in GitHub" had changed and caused this issue, because it worked smoothly a while ago!). And I played a bit with some some comments from the linked issue, and this change seems to resolve the problem:

https://github.com/javagl/sandbox/commit/297d322b2efd26f3dc1ac477ac047fe79aff5292

Maybe we want to try this out here as well.

javagl commented 9 months ago

I opened a PR with an attempt to fix this at https://github.com/KhronosGroup/glTF-Sample-Assets/pull/28 , maybe someone wants to have a look.

javagl commented 8 months ago

I'll just claim that it is not possible to use GitHub actions for the tasks that are required for this repository.

(It's not that I think that it is not possible. It was possible until a few weeks ago, and then someone screwed things up. I just claim that it is not possible)

We should remove the failing GitHub action, and someone should manually update the model index periodically.

DRx3D commented 7 months ago

The action has been changed to just perform the necessary consistency checks and report the results. The build of the repo indices is still a manual operation. Leaving this issue open until the build of the repo can be addressed.

javagl commented 7 months ago

Replaced by https://github.com/KhronosGroup/glTF-Sample-Assets/issues/54