search

KhronosGroup / glTF-Sample-Assets

To store all models and other assets related to glTF
256 stars 30 forks source link

Use KHR_materials_transmission in FlightHelmet #34

Closed mrdoob closed 7 months ago

mrdoob commented 8 months ago

Every engine seem to be handling alphaMode: BLEND differently (used in the glasses):

Screenshot 2023-10-17 at 4 28 19 PM

KHR_materials_transmission seems to have better alignment so I propose updating this model with the extension.

/cc @elalish

andreasplesch commented 8 months ago

On the other hand, the model shows off well what is possible without using extensions. An appropriate response may include addressing what the root cause of the differing interpretations is as the sample assets serve mostly this purpose.

bghgary commented 8 months ago

In Babylon.js, we turn on reflections by default because that's what most people expect. It can be turned off to be spec-conformant. We probably should enable this flag in the model viewer test code.

elalish commented 8 months ago

Yeah, the root cause of the differing interpretations is spec non-conformance because people wanted to do glass with alpha, which isn't correct, and hence why the transmission extension was added. I think this model should definitely be updated, because using alpha for glass is simply incorrect. @bghgary would you like to send a PR to update Babylon in our fidelity tests?

elalish commented 7 months ago

It appears I have the permissions, so I'm going to go ahead and merge this unless someone gives me a good reason not to. Is that okay @DrX3D?

mrdoob commented 7 months ago

Unable to fix these checks. Second attempt: https://github.com/KhronosGroup/glTF-Sample-Assets/pull/48