KhronosGroup / glTF-Sample-Assets

To store all models and other assets related to glTF
256 stars 30 forks source link

Folder and File Structure standards? #39

Open echadwick-artist opened 8 months ago

echadwick-artist commented 8 months ago

I think we could use some standardization for folders and files.

There are a few of the unwritten rules I learned from other contributors a few years ago, when I started submitting assets to these repos.

I think these rules should be codified into the SubmittingModels.md documentation, but I would like feedback from other contributors before we add this additional section. There are also a few typos in the md, but those shouldn't require discussion.

I propose to add this section to SubmittingModels.md :

Folder and File Structure

Folder and file names must be consistent as this helps with tooling and automation.

echadwick-artist commented 7 months ago

Rethinking this sentence:

PNG textures are preferred to avoid compression artifacts; if a variant is desired with .jpeg resources it can be provided in a /glTF-JPG subfolder (see below).

I think reducing file size for the repo is an important consideration, and JPEG compression should be recommended for asset in the main \glTF folder.

Should we include a \Source-Assets folder, including the DCC-native model source format, and uncompressed textures in PNG format?

lexaknyazev commented 7 months ago

JPEG compression should be recommended for asset in the main \glTF folder.

Only for color textures and only if compression artifacts are not visible.

echadwick-artist commented 7 months ago

Thanks Alexey. Updated:

Folder and File Structure

Folder and file names must be consistent as this helps with tooling and automation.

lexaknyazev commented 7 months ago

screenshot_Large

Inconsistent spelling here. Should be either screenshotLarge or screenshot_large. The latter would be my preference.


/glTF-PNG

Consider suggesting hi-res images in this case.


Should there be a standard name for meshopt-compressed assets?

spnda commented 3 months ago

Should there be a standard name for meshopt-compressed assets?

Also, is there any particular reason why all sample models for EXT_meshopt_compression were removed for this repository? I use them in my testing CI, and these removals are currently keeping me from switching.

emackey commented 1 month ago

@spnda The missing models have returned in #124.

javagl commented 1 month ago

It's good that this issue was "bumped", because ... it's still open, and there are some open questions.

The information from the updated "Folder and File Structure" list above could be inserted somewhere near https://github.com/KhronosGroup/glTF-Sample-Assets/blob/main/SubmittingModels.md#requirement-details

(Beyond that: IIRC, when I submitted the last model, it wasn't perfectly clear for me which parts of the metadata JSON have to be provided in which form, but maybe that can be clarified in a PR that addresses this issue as well)