search

KhronosGroup / glTF-Sample-Assets

To store all models and other assets related to glTF
257 stars 30 forks source link

Contribution reqs for this repo #46

Open lexaknyazev opened 7 years ago

lexaknyazev commented 7 years ago

I propose that all sample models satisfy these two reqs:

  1. If a model was created by some software tool (e.g., exporter or converter), it MUST contain asset.generator property with software's name and version.
  2. Models must have asset.copyright property and/or README.md file with attributions and usage info.

CC @pjcozzi @bghgary @javagl

pjcozzi commented 7 years ago

OK with me. Feel free to open a PR to update the Contributing Sample Models section.

Later, this can also be checked with CI, KhronosGroup/glTF-Sample-Models#26

DRx3D commented 8 months ago

This issue has not been touched in 6+ years. Has the new repo with metadata resolved this? @lexaknyazev , @pjcozzi

javagl commented 8 months ago

The requirements in the new repo probably do address what may have been the spirit behind bringing up this issue here.

The copyright, as it was described here, would be something that would be inextricably linked to the asset itself, which could be beneficial, compared to the "external" license info in the new repo. But requiring it in the asset itself may raise some detail questions. Some of them also apply to the "external" license info, but for example: Which "format" should it have (are SPDX identifiers required)? Can it contain Markdown? Do applications usually load and display it? And the most difficult one: What happens when someone edits/post-processes the asset?

The generator is even less strict. When loading and re-exporting a model (even without modifications), tools often write their name into the generator field. There are even fewer technical requirements here.