search

KhronosGroup / glTF-Sample-Assets

To store all models and other assets related to glTF
257 stars 30 forks source link

How should different screenshot sizes be handled? #49

Open javagl opened 1 year ago

javagl commented 1 year ago

Inspired by a comment in a PR:

There is a convention to add a file /screenshot/screenshot.* for each model. This screenshot is used as a preview in the table in the main 2.0/README.md file.

There are some samples where the screenshot can be pretty small - for example, all the basic Simple... models and others. For other screenshots that show nice rendering features, there should be at least one large screenshot that shows the rendered result in high resolution. (Some models already do that, by adding a screenshot.* for the preview, and a screenshot_large.* to be embedded in the respective README).

  1. Should the /screenshot/screenshot.* file be explicitly required to be a "small" one, with low resolution and file size? I think that one could argue that it should be small, so that the preview page is loaded quickly.

  2. Should the screenshots in the table be fixed to a certain width? I think that the "jagged" display that results from different-sized screenshots is not so pretty. As an example, showing one table once in the current form and once with fixed image widths:

    Khronos glTF Screenshot sizes

    (This may raise questions about the desired aspect ratio of the screenshots, but I think that fixing the width could make sense...)

cx20 commented 1 year ago

@javagl Thank you for taking up this issue.

Should the /screenshot/screenshot.* file be explicitly required to be a "small" one, with low resolution and file size?

I use screenshot for listing in the following repository. However, I don't think that too large images are suitable as they take a long time to load. (The impression that it takes a long time to load is subjective and may not be that heavy depending on your PC and network environment.)

https://github.com/cx20/gltf-test https://cx20.github.io/gltf-test/

It may be more correct to call it a thumbnail rather than a screenshot as the image used for the list display.

Should the screenshots in the table be fixed to a certain width?

Yes, I think it would look better if it were aligned at a fixed fixed width rather than "jagged" as you suggest.

echadwick-artist commented 10 months ago

It would be helpful to write a specification for screenshot_large. This could be added to pull request https://github.com/KhronosGroup/glTF-Sample-Assets/pull/17 .

Perhaps we could specify a minimum resolution of 1280 pixels for the longest dimension, for example 1280x720 which is 720p HD.

The guideline for screenshot_large should be added to the new glTF Sample Assets repo, which is in open beta and is meant to supersede the existing glTF Sample Models repo.

DRx3D commented 7 months ago

Transferring to Sample Assets so it can be handled there and included in CI.