Open javagl opened 1 year ago
Answering some of the questions.
license
is the official name of the license. There are several variants of the CC license that map to the same legal license.spdx
is the reuse name of the license.text
is the standardized human-readable version. 'spdx' is almost always determined from 'text'. If a non-standard license is used, special considerations and handling need to be performed.icon
is really only used for CC licenses. It might need to be enforced.CreateJson.html
file creates a valid metadata.json file. The creator fills in fields and the populates and displays the JSON structure. That s/w is in beta ATM.I am not going to claim everything is the correct way here. There is likely a better way to do this, and I am completely open to changing this.
The
SubmittingModels.md
may have to be reviewed.Things that are fixed in the current state of this PR:
#converters
. Minor rewording of the variants. Added requirement that models pass validation (!)metadata.json
Here, I stumbled: The description of the JSON there is a bit incomplete, and I'm not sure how to complete this:
version: 2
? (I wondered whether this referred to glTF itself...).tags
? (Yeah, 🐘 -> 🏠 )name
: The name of the subdirectory that the model is contained inpath
: The path of the model subdirectory, relative to the repository rootscreenshot
: The path to the screenshot, relative to the model subdirectorysummary
: A short description of what the model is or demonstratescreateReadme
: Should always betrue
The
legal
part also does not seem to list everything that can be found in the actual JSON files. One example isThat looks like a lot of redundant redundancy, which is pretty redundant.
license
andspdx
? Iflicense
is only intended for non-spdx licenses, then I wonder whether this could be merged intolicense
, with the values either being one of the spdx-identifiers, or"Custom"
.text
really only for the link text, and does it make a difference of whether the link text is CC-BY 4.0 or CC-BY 4.0 International ?icon
link... hm. Is this necessary and useful? Even if the answer is 'yes': Is "hotlinking" to a random PNG file the right thing to do here...?And... most importantly: What exactly do submitters have to do here? Which of these fields are (or can be) auto-filled: I've seen that link to the
CreateJson.html
(which of course does not work on GitHub...), but is this supposed to fill out most of this information based on less input? Users shouldn't have to figure out thelicenseUrl
on their own, and it would be hard to make sure that the information in the given form is consistent ...