KhronosGroup / glTF-Sample-Assets

To store all models and other assets related to glTF
257 stars 30 forks source link

Updated submission info #5

Open javagl opened 1 year ago

javagl commented 1 year ago

The SubmittingModels.md may have to be reviewed.

Things that are fixed in the current state of this PR:

Here, I stumbled: The description of the JSON there is a bit incomplete, and I'm not sure how to complete this:

The legal part also does not seem to list everything that can be found in the actual JSON files. One example is

            "license": "CC-BY 4.0",
            "licenseUrl": "https://creativecommons.org/licenses/by/4.0/legalcode",
            "artist": "Cesium",
            "year": "2017",
            "owner": "Cesium",
            "what": "Everything",
            "text": "CC BY 4.0 International",
            "spdx": "CC-BY-4.0",
            "icon": "https://licensebuttons.net/l/by/3.0/88x31.png"

That looks like a lot of redundant redundancy, which is pretty redundant.

And... most importantly: What exactly do submitters have to do here? Which of these fields are (or can be) auto-filled: I've seen that link to the CreateJson.html (which of course does not work on GitHub...), but is this supposed to fill out most of this information based on less input? Users shouldn't have to figure out the licenseUrl on their own, and it would be hard to make sure that the information in the given form is consistent ...

DRx3D commented 1 year ago

Answering some of the questions.

I am not going to claim everything is the correct way here. There is likely a better way to do this, and I am completely open to changing this.