search

KhronosGroup / glTF-Sample-Assets

To store all models and other assets related to glTF
257 stars 30 forks source link

Some models are unwelded #60

Open prideout opened 5 years ago

prideout commented 5 years ago

Several models (like Suzanne) have their index count == vertex count and therefore have redundant index buffers.

This is a visualization of Suzanne's tangent vectors: 59386035-93368280-8d1a-11e9-8218-8791cb10000f

DRx3D commented 7 months ago

This issue has not been commented on in 4 years. Is it still of concern @prideout in the Sample-Assets repo? If so, it will be transferred; otherwise, closed by 27 November. No response results in closing this issue.

prideout commented 7 months ago

I think we would all agree that any sample mesh whose index count == vertex count is a poor exemplar for glTF. Maybe just remove it from the repo, or run it through gltf-transform?

donmccurdy commented 7 months ago

With glTF Transform v3.9 this can, if desired, be detected and fixed:

gltf-transform prune in.glb out.glb --keep-indices false

I'll most likely turn the --keep-indices flag on by default in v4.

lexaknyazev commented 7 months ago

The fix should happen in the new repo.