Dedicated test for correct pixel transfer functions

KhronosGroup / glTF-Sample-Assets

To store all models and other assets related to glTF

349 stars 36 forks source link

Dedicated test for correct pixel transfer functions #68

Open lexaknyazev opened 3 years ago

lexaknyazev commented 3 years ago

As of today, only four glTF color textures use sRGB encoding:

emissiveTexture
pbrMetallicRoughness.baseColorTexture
KHR_materials_pbrSpecularGlossiness.specularGlossinessTexture
KHR_materials_sheen.sheenColorTexture

All other textures are sampled linearly. We need dedicated test models that would highlight potential implementation errors in that area.

It's important to note, that working with linear 8-bit values in DCC tools could be quite challenging as some editors may misrepresent such content on screen and show misleading color-picker values.

donmccurdy commented 3 years ago

If we create test assets for these cases, I would prefer to use KHR_materials_specular (https://github.com/KhronosGroup/glTF/pull/1719) over KHR_materials_pbrSpecularGlossiness. Fine to have both, too, but the emphasis will be more on the first moving forward.

emackey commented 2 years ago

Is this resolved now?

lexaknyazev commented 2 years ago

I'd prefer to keep this open until we have similar tests for:

KHR_materials_pbrSpecularGlossiness.diffuseTexture
KHR_materials_pbrSpecularGlossiness.specularGlossinessTexture
KHR_materials_sheen.sheenColorTexture
KHR_materials_specular.specularColorTexture

Although the SpecGloss is deprecated, Sample-Viewer had a bug with it and the sheen color: https://github.com/KhronosGroup/glTF-Sample-Viewer/issues/295.

DRx3D commented 10 months ago

This issue has been opened for almost 3 years. Since the repo has moved and there is a request to keep it open until certain things are done, should this be transferred to Sample-Assets? If there is no response, the issue will be transferred to Sample Assets by 17 Nov.