KhronosGroup / glTF-Sample-Assets

To store all models and other assets related to glTF
257 stars 30 forks source link

Update to Review Policy #7

Closed DRx3D closed 11 months ago

DRx3D commented 1 year ago

Multiple updates included in this PR including:

Discussion of missing items in PR#5 has not yet been addressed and must be in the near future.

javagl commented 1 year ago

Regarding the last commit, just to keep track of this: The changes from #5 that are not included in the updated state of SubmittingModels.md are

The last point may not have addressed here, but should be sorted out either in an issue or a dedicated PR: We should be really, really careful to make sure that there is a place where the real SPDX license identifier can reliably be found, in a way that is machine-processable and unambiguous

(As in if (spdxLicenses.includes(thatValue)) { weKnowWhatToDoWithThat(); }...)

And in these identifiers ...

DRx3D commented 12 months ago

@javagl : Please take a look at the revised version (direct link). I incorporated your changes and redid the descriptions of licenses at the end.

javagl commented 12 months ago

Looks fine for me. I guess that I'll close #5 soon then. Even if there are open questions, the PR itself has probably become obsolete.