Second Sync Update - Githubissues

KhronosGroup / glTF-Sample-Assets

To store all models and other assets related to glTF

255 stars 30 forks source link

Second Sync Update #86

Open DRx3D opened 6 months ago

DRx3D commented 6 months ago

The models added here need some assistance - mostly descriptions. This is meant to be applied after PR #85 and after the 'issues' tag has been removed.

The new models in this PR are:

ClearcoatRing
ClearcoatSphere
SheenHighHeel
SuzanneMorphSparse
TransmissionSuzanne

In addition other models may have had various updates to READMEs to improve the formatting.

DRx3D commented 6 months ago

All of the models listed in this PR all need descriptions. Most were supplied by UX3D. Tagging a few UX3D people to attract their attention. The model description can be added as a comment and I will get it into the system. You can also create a PR against the forked branch if it is a substantial change.

@UX3D-becher , @UX3D-haertl , @UX3D-kanzler

Model READMEs (from the PR source)

DRx3D commented 6 months ago

@javagl, @lexaknyazev : The SuzanneMorphSparse model needs a description. Can either of you provide something simple for this?

javagl commented 6 months ago

Maybe this was already supposed to be reviewed, and I missed it, but I'd suggest to not include SuzanneMorphSparse in its current form.

It claims to use KHR_materials_unlit and KHR_texture_transform but uses neither of these
It contains some undocumented/useless extras
It contains a node that has rotation/translation/scale set, but all with their default values
Most importantly: It does not contain any morph animation.

I don't know where the screenshot GIF comes from, but none of the common viewers that I tried shows anything "animated" there. (That small white thing that appears (in the GIF) in the lower left when the eyes are closed are a minor detail at this point...)

I know that this means that https://github.com/KhronosGroup/glTF-Sample-Assets/issues/61 will remain open, but... that's what it is for now.

lexaknyazev commented 6 months ago

It contains some undocumented/useless extras

Those are actually spec-suggested, see the note at the end of the Morph Targets spec section. Agreed with all other points.

There's also inconsistent indentation in SuzanneMorphSparse/metadata.json.

DRx3D commented 5 months ago

Changed to Draft so comments can be resolved without merging.