Sync 1 - Githubissues

KhronosGroup / glTF-Sample-Assets

To store all models and other assets related to glTF

255 stars 30 forks source link

Sync 1 #87

Closed DRx3D closed 5 months ago

DRx3D commented 6 months ago

Added several new models that were unique to glTF-Sample-Models. Also updates to the generator program to include a list of model extensions (used and required).

DRx3D commented 6 months ago

This needs to be merged before #86. After merging #86 may have synchronization issues that need to be resolved.

DRx3D commented 6 months ago

@echadwick-artist, @emackey: Can either of you take a quick look at this PR to make sure the model quality is good. The new models came from glTF-Sample-Models that had not been merged into this repo.

DRx3D commented 6 months ago

All models have a new README with a listing of extensions used & required. Some models have updated Metadata file to better describe the license for that model

Listing of new models

CarbonFibre
ChairDamaskPurpleGold
DiffuseTrasmissionPlant
DiffuseTransmissionTeacup
DirectionalLight
PrimitiveModeNormalsTest
VirtualCity (was VC)
XmpMetadataRoundedCube

This PR will remain open until 4 Jan 2024 to allow people to comment (due to the holidays).

echadwick-artist commented 6 months ago

The changes look good to me. I made a few changes to the models I worked on. Looked at a representative sampling of the MD files, the additions and fixes look good.