KhronosGroup / glTF-Sample-Models

glTF Sample Models
3.11k stars 1.3k forks source link

Add glTF 1.1 models from the upcoming glTF tutorial #16

Closed pjcozzi closed 7 years ago

pjcozzi commented 7 years ago

@javagl for the models in https://github.com/javagl/gltfTutorialModels, do you prefer:

javagl commented 7 years ago

I don't have a strong preference here. Conceptually, they are a bit different than the other models, because they are small, hand-crafted, feature-based examples, and some of them use a mixed structure (with embedded buffers but external shaders) for easier presentation in the tutorial.

If they are moved to the official sample models repo, then they could

In any case, I agree to what you mentioned in the second point: It could be useful to link from the tutorial to the models. Either via a list in an appendix, or inlined: "Here is an example ... it can be downloaded from the sample models repo at (link)". Similarly, one could add a link to the README of the models: "SimpleSkin. Skinning is explained in the tutorial at (link)"

If they should be added here, then just drop me a note, and I will create a PR to start filling the 1.1 directory :-)

pjcozzi commented 7 years ago

either appear as "Test cases/models" in a dedicated list

Good idea, let's do this. Looking forward to the pull request!

javagl commented 7 years ago

Done ("accidentally") as discussed in https://github.com/KhronosGroup/glTF-Sample-Models/pull/18#issuecomment-272644365