search

KhronosGroup / glTF-Sample-Models

glTF Sample Models
3.13k stars 1.31k forks source link

Squash-commit of optimized LightsPunctualLamp model from DGG. #354

Closed emackey closed 2 years ago

emackey commented 2 years ago

This is a continuation of #347.

@mlimper @teresavieggas Are you OK with this?

mlimper commented 2 years ago

Oh thanks Ed, this is very kind - yes, fine with this!

cx20 commented 2 years ago

Thank you for providing a great model. BTW, It may be a matter of taste, but I thought it would be easier to compare and understand if the lamp could be turned on and off like the StainedGlassLamp.

emackey commented 2 years ago

@cx20 Yes, but that doesn't quite work here with the use of KHR_lights_punctual, which cannot be affected by material variants. There's an upcoming "animation pointer" extension that might be able to animate the brightness of a punctual light (to turn it on or off), but that's still in the draft phase for now.

cx20 commented 2 years ago

@emackey Thanks for letting us know. I look forward to future improvements. The "animation pointer" is one of the extensions I am looking forward to.