search

KhronosGroup / glTF-Sample-Models

glTF Sample Models
3.13k stars 1.31k forks source link

Anisotropy test model? #393

Closed bhouston closed 1 year ago

bhouston commented 1 year ago

I notice that we are missing any anisotropy models/examples. I think it would be useful to have a test model that shows off anisotropy in a few different scenarios.

The two main use cases for anisotropy are basically:

  1. A circular anisotropy, like on the bottom of a pot
  2. A carbon fibber weave anisotropy, everyone loves this.

Then I think there are a few complications that we could demonstrate to ensure people implement it correctly:

  1. The above scenarios where the anisotropy texture is rotated via the texture extension (does the anisotropy rotate or not? should it?)
  2. The above with an additional normal map on it.
  3. The above with a clear coat on top.

cc: @echadwick-artist

bhouston commented 1 year ago

We noticed this as we are adding Blender Cycles and Chaos V-Ray to @elalish's Model Viewer fidelity test suite:

echadwick-artist commented 1 year ago

Thanks for the shout-out Ben.

We have some test models in the new glTF Sample Assets repo, which is meant to replace glTF Sample Models (once we get the kinks worked out).

For additional normal maps, I noticed bump details don't light well when anisotropy is present. I showed an example of this in the recent Khronos webinar I did, here's the video https://www.youtube.com/watch?v=PyMgrV8BErY&t=1377s

bhouston commented 1 year ago

Amazing! Of course you are on top of it @echadwick-artist , we just need to deprecate this repo because it is the duplicate repos that is causing the confusion.

EricChadwick commented 1 year ago

We could use some assistance in finalizing the automated checks in the new repo.

bhouston commented 1 year ago

I've created a pull request here for model-viewer render fidelity tests for these 3 models: https://github.com/google/model-viewer/pull/4493

bhouston commented 1 year ago

Closing as we've achieved our results!