KhronosGroup / glTF-Sample-Viewer

Physically-Based Rendering in glTF 2.0 using WebGL
Apache License 2.0
1.21k stars 229 forks source link

"Main" debug view for extension should show complete effect #507

Closed echadwick-artist closed 3 weeks ago

echadwick-artist commented 6 months ago

The "main" debug view for an extension should show the entire effect including all its parameters.

Otherwise it would be showing the full strength of the effect? This would IMHO not be helpful for debugging purposes.

For example, the debug view "Clearcoat" should show the combined result of all the ingredients in the material:

  1. clearcoatFactor
  2. clearcoatTexture
  3. clearcoatRoughnessFactor
  4. clearcoatRoughnessTexture
  5. clearcoatNormalTexture

When using this mode with the ClearCoatTest model, it seems to be including clearcoatRoughnessTexture and clearcoatNormalTexture but not clearcoatTexture? This seems like an omission.

2023-11-20 14_49_24-glTF Sample Viewer

2023-11-20 14_49_32-glTF Sample Viewer 2023-11-20 14_49_36-glTF Sample Viewer 2023-11-20 14_49_41-glTF Sample Viewer 2023-11-20 14_49_17-glTF Sample Viewer Thanks!