KhronosGroup / glTF-Sample-Viewer

Physically-Based Rendering in glTF 2.0 using WebGL
Apache License 2.0
1.29k stars 238 forks source link

http://gltf.ux3d.io transforms incorrect for KHR_animation_pointer #539

Closed echadwick-artist closed 3 months ago

echadwick-artist commented 8 months ago

I’m able to drag-and-drop this asset into glTF Sample Viewer (https://github.khronos.org/glTF-Sample-Viewer-Release/) and see the correct transforms: 2024-04-06 09_43_01-glTF Sample Viewer

Animation is not rendered, since this uses KHR_animation_pointer and the viewer does not support it yet, so I try to use the UX3D dev viewer (http://gltf.ux3d.io/), but when I try to drag-and-drop into the dev viewer the transforms are incorrect (although animation does play!): 2024-04-06 09_43_18-glTF Sample Viewer

Here is the glTF: animationPointerUVs_2024-04-04.zip

Thanks!

UX3D-haertl commented 7 months ago

The animation pointer extension implementation in the UX3D viewer is currently outdated. Adding support for KHR_animation_pointer to this repo is already planned and approved by Khronos and will be worked on in the upcoming months.

echadwick-artist commented 7 months ago

Thank you for the update Patrick!

UX3D-haertl commented 3 months ago

We updated the animation_pointer extension, so the assets works as expected again. But for some reason, which I can currently not figure out, the texture transform for diffuse transmission does not work. As far as I see we are changing the UV values but there is no visual difference. Not exactly sure why, since we handle texture transforms the same for all extensions

echadwick-dgg3d commented 3 months ago

Have you tried the latest version of the asset, which is here? https://github.com/KhronosGroup/glTF-Sample-Assets/pull/115

UX3D-haertl commented 3 months ago

Just try it with the newest version but diffuese transmission still does not work

echadwick-dgg3d commented 3 months ago

Hmm. I remember Babylon had some initial trouble getting it to work, maybe their reply here can help? https://forum.babylonjs.com/t/khr-animation-pointer-with-uv-transforms/49081/46?u=echadwick-artist

There's also an isolated test case I made, just above that reply.

Good luck!