KhronosGroup / glTF-Sample-Viewer

Physically-Based Rendering in glTF 2.0 using WebGL
Apache License 2.0
1.28k stars 235 forks source link

Hide warnings for MESH_PRIMITIVE_GENERATED_TANGENT_SPACE #588

Open emackey opened 15 hours ago

emackey commented 15 hours ago

During the 3D Formats WG call today (2024-11-13), we discussed validation warnings that appear on many showcase models, reported by the validator as MESH_PRIMITIVE_GENERATED_TANGENT_SPACE and appearing in the Sample Viewer as a loud yellow number to the side of the model. @lexaknyazev and I talked through why this warning exists in the validator, but we agreed that it does not need to appear on the UI of viewers such as this one where tangent space generation is a known feature of the rendering engine.

So the discussion ended today with a decision to suppress the warning from the UI using the glTF Validator's ignoredIssues feature.

PR incoming.

emackey commented 15 hours ago

/cc @DRx3D