KhronosGroup / glTF

glTF – Runtime 3D Asset Delivery
Other
7.19k stars 1.14k forks source link

KHR_materials_volume extension doesn't state intended color spaces for properties #2322

Open hybridherbst opened 1 year ago

hybridherbst commented 1 year ago

While looking into a few color management problems I've come across at least one extension where the intended color space is not specified.

These readmes explicitly mention intended color space:

These don't:

lexaknyazev commented 1 year ago

The base spec and all extensions follow the same rules:

Volume attenuation color is a bit unique because it is not texturable but the general rule still applies: JSON numbers are linear. We should clarify the extension spec.

/cc @emackey

donmccurdy commented 1 year ago

I really wish we could use the terms "Linear", "sRGB" or "Rec. 709", and "D65" when describing these factors. I understand that we're dancing around a tricky distinction — multiplicands whose product is a Linear-Rec709-D65 color. But I don't think "linear multiplier" is giving the reader enough context to understand that. Particularly as more tools begin supporting additional linear color spaces.