Tracker for adding glslang support for versioned shared objects / DLLs

[ben-clayton]

This issue tracks the work being done to add support for versioned shared objects / DLLs for glslang.

• [x] Untangle cyclic build target dependencies. Status: Done - #2271
• [x] Switch to using Semantic Versioning. Status: Done - #2277
• [x] Add SONAME library versioning. Status: Done - #2277
• [x] Add presubmit builds for CMake, Android.mk. Status: Done - #2281
• [x] Add presubmit builds for shared objects. Status: Done - #2286
• [x] glslang
  • [x] Reduce glslang exported symbols to public API. Status: Done - #2303
  • [x] Export DLL glslang public API symbols. Status: Done - #2303
• [ ] SPIRV
  • [ ] Determine SPIRV public API. Status: Not started
  • [ ] Reduce SPIRV symbols to public API. Status: Not started
  • [ ] Export DLL SPIRV API symbols. Status: Not started
• [ ] Fix ODR violations between glslang and SPIRV shared objects. Status: WIP - #2336, #2348
• [ ] Presubmit detection & warnings when making breaking API changes without bumping major version. Status: Not started

---

Related issues: #1255, #1421, #1484, #2147, #2267

[johnkslang]

Note that #2277 is still WIP, but now #2282 is not. Is there any dependency?

[ben-clayton]

I want to add presubmit builds for SOs / DLLs to check #2282 is safe to land. I've locally tested #2282, but I always like to get a second opinion.

I'll do that now.

[jspanchu]

Few symbols that are exported from glslang shared library are not at all defined. For example, symbols of TShader are exported in glslang, however they are declared in MachineDependent which is a hard-coded static library built without GLSL_EXPORT.

It is probably simpler by building your implementation modules GenericCodeGen, MachineDependent, OSDependent into object libraries. Does anyone downstream really link to them?