search

KhronosGroup / glslang

Khronos-reference front end for GLSL/ESSL, partial front end for HLSL, and a SPIR-V generator.
Other
3.01k stars 829 forks source link

Update version of macOS deployment GHA runner #3451

Closed ncesario-lunarg closed 9 months ago

ncesario-lunarg commented 9 months ago

@juan-lunarg Should we be setting MACOSX_DEPLOYMENT_TARGET in our builds as well?

CLAassistant commented 9 months ago

CLA assistant check
All committers have signed the CLA.

juan-lunarg commented 9 months ago

@juan-lunarg Should we be setting MACOSX_DEPLOYMENT_TARGET in our builds as well?

I found no one was keeping it up to date. So I'm hesitant to recommend it.

That's why I added the usage of the macos-11 runners.

You can also wait until this issue gets fixed and continue using macos-11 runners with the latest version of CMake: https://github.com/lukka/get-cmake/issues/98

Or remove usage of get-cmake for macos continuous deployment since the cmake version for macos-11 that comes with the docker container is good enough: https://github.com/actions/runner-images/blob/main/images/macos/macos-11-Readme.md

ncesario-lunarg commented 9 months ago

I don't have a strong preference. @arcady-lunarg?

juan-lunarg commented 9 months ago

You can also wait until this issue gets fixed and continue using macos-11 runners with the latest version of CMake: https://github.com/lukka/get-cmake/issues/98

Looks like lukka just fixed this. Just a matter of time before the bots update the dependency now.

ncesario-lunarg commented 9 months ago

In that case I'll wait to see if the next deployment is successful before merging this.

juan-lunarg commented 9 months ago

Looks like dependabot is set to only run 3 times a week. Meaning get-cmake won't be updated till next week with the fix. Unless you just wanna update it manually.

ncesario-lunarg commented 9 months ago

This was resolved by https://github.com/KhronosGroup/glslang/pull/3456.