Add github action for testing cmake installation

KhronosGroup / glslang

Khronos-reference front end for GLSL/ESSL, partial front end for HLSL, and a SPIR-V generator.

Other

3.01k stars 829 forks source link

Add github action for testing cmake installation #3462

Open ncesario-lunarg opened 9 months ago

ncesario-lunarg commented 9 months ago

Add a test that exercises cmake's find_package for all installed targets. These currently include:

[ ] glslang::OSDependent
[ ] glslang::glslang
[ ] glslang::MachineIndependent
[ ] glslang::GenericCodeGen
[ ] glslang::glslang-default-resource-limits
[ ] glslang::glslang-standalone
[ ] glslang::spirv-remap
[ ] glslang::SPVRemapper
[ ] glslang::SPIRV

juan-lunarg commented 9 months ago

For reference I have added testing for find_package in the Vulkan-Loader. It's run via ctest: https://github.com/KhronosGroup/Vulkan-Loader/pull/1423

This makes it trivial to test.

juan-lunarg commented 9 months ago

glslang::OSDependent I'd argue should NOT be installed. It's useless to end users. Making it an object library will prevent it from getting installed on users machines. While still keeping the abstraction.

Ping @arcady-lunarg since I talked about this with them in chat before.

arcady-lunarg commented 9 months ago

Yes, OSDependent, MachineIndependent, and GenericCodeGen are not for end user use and should be object libraries.