Added flag to output absolute paths for errors & warning

KhronosGroup / glslang

Khronos-reference front end for GLSL/ESSL, partial front end for HLSL, and a SPIR-V generator.

Other

2.91k stars 817 forks source link

Added flag to output absolute paths for errors & warning #3466

Closed Sharlock93 closed 6 months ago

Sharlock93 commented 6 months ago

Uses std::filesystem to generate an absolute path when outputting errors and warnings. I needed this myself for easy jumps in vim. This was also requested in this issue https://github.com/KhronosGroup/glslang/issues/2717

Please let me know if this is a "viable" solution or if I'm missing something in terms of contribution etiquette. It seemed the most straight forward way to add this given the C++17 requirement.

CLAassistant commented 6 months ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Sharlock93 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

arcady-lunarg commented 6 months ago

Yes, using std::filesystem is fine, indeed there is already some precedent for it in spirv-remap.

Sharlock93 commented 6 months ago

Sorry I closed the PR because the commit had a different email compared to my github one and it triggered a bunch of stuff, I'm preparing a different PR with correct github user. Thanks for the confirmation.