search

KhronosGroup / glslang

Khronos-reference front end for GLSL/ESSL, partial front end for HLSL, and a SPIR-V generator.
Other
2.9k stars 816 forks source link

Improve gtest infra and add include file test #3535

Closed qingyuanzNV closed 3 weeks ago

qingyuanzNV commented 4 months ago

This is the infra part of change from https://github.com/KhronosGroup/glslang/pull/3513

arcady-lunarg commented 4 months ago

Part of this is addressed by #3375 which I am going to actually merge shortly because I finally figured out the line endings issue, so you're going to have to rebase this, but you also should have fewer CI problems.

qingyuanzNV commented 4 months ago

Okay. I'll rebase after that one is merged.

arcady-lunarg commented 4 months ago

The other change has been merged now.

arcady-lunarg commented 3 months ago

Looks like more line ending problems, ugh.

arcady-lunarg commented 3 months ago

Looks like the failures are line ending issues, make sure you're adding both the test file and the result file with line endings that are consistent between the two of them, I think probably unix line endings would work better in this case.

qingyuanzNV commented 3 months ago

Yeah, I guessed the same. I'm quite busy with some other deadline recently and I'll get back to this tomorrow.

qingyuanzNV commented 2 months ago

@arcady-lunarg sorry to get back to this late. I have addressed the line-ending issue for all test files. Please help review and squash with the following commit message.

Improve gtest infra for includer support and add include file test
- Add includer to gtest for include file tests.
- Move some tests from legacy script to gtest.
arcady-lunarg commented 2 months ago

@qingyuanzNV I think you need to move the test back to the runtests script, it is there because it gets run twice with different command line options, for one thing one version is run with -G and the other with -V.

arcady-lunarg commented 3 weeks ago

I've rebased the branch and pushed a commit to undo the moving of that one test from runtests to gtest. Otherwise I think the changes are good.