Using std::make_unique C++17 in some functions

KhronosGroup / glslang

Khronos-reference front end for GLSL/ESSL, partial front end for HLSL, and a SPIR-V generator.

Other

2.9k stars 815 forks source link

Using std::make_unique C++17 in some functions #3565

Closed GermanAizek closed 2 months ago

GermanAizek commented 3 months ago

If contributors approve my changes, I can fix them for all instructions.

arcady-lunarg commented 3 months ago

You should probably run the same tests that get run in CI before you make a pull request, for example I run ninja -C build test (make sure you've run update_glslang_sources.py and that building of tests is enabled).

arcady-lunarg commented 2 months ago

Given this didn't pass CI as it caused crashes and hasn't been updated for a couple weeks, I am going to close this for now.