search

KhronosGroup / glslang

Khronos-reference front end for GLSL/ESSL, partial front end for HLSL, and a SPIR-V generator.
Other
2.9k stars 815 forks source link

ABI break in glslang-14.2 #3593

Closed jengelh closed 2 months ago

jengelh commented 2 months ago

Regression #3052 #3311 #3312

$ abidiff libglslang.so.14.1.0 libglslang.so.14.2.0

Functions changes summary: 1 Removed, 3 Changed (887 filtered out), 1 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

1 Removed function:

  [D] 'method bool glslang::TIntermediate::improperStraddle(int, int)'    {_ZN7glslang13TIntermediate16improperStraddleERKNS_5TTypeEii}

1 Added function:

  [A] 'method bool glslang::TIntermediate::improperStraddle(int, int, bool)'    {_ZN7glslang13TIntermediate16improperStraddleERKNS_5TTypeEiib}
arcady-lunarg commented 2 months ago

While this symbol is indeed exposed in the .so, it's not in any of the installed header files so I would not consider this a real ABI break. We're still working on getting -fvisibility=hidden to work properly in the glslang build.