KhronosGroup / glslang

Khronos-reference front end for GLSL/ESSL, partial front end for HLSL, and a SPIR-V generator.
Other
2.9k stars 815 forks source link

Add column to location logs. #3614

Open antaalt opened 1 month ago

antaalt commented 1 month ago

The column is never printed to error logs. This commit simply add the column to the log after the line. This is really useful for external linting applications that will locate the error for user.

The issue here is that this might be a breaking change as some external parser might be relying on the log format to work correctly, still I think it should be pushed in order to be used as an efficient linter.

This is solving this issue

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

arcady-lunarg commented 4 weeks ago

I think this is a good idea in principle, you're almost certainly going to need to update some test results though, and also check that the column numbers are actually valid in those test results, since it's likely nobody's actually checked the column numbers since they were never really visible.

antaalt commented 3 weeks ago

I have checked that the column display is valid using vscode-glsllint and it seems to be working fine