search

KhronosGroup / glslang

Khronos-reference front end for GLSL/ESSL, partial front end for HLSL, and a SPIR-V generator.
Other
3.08k stars 844 forks source link

Externals headers reference incorrect path #3750

Open Shoegzer opened 1 month ago

Shoegzer commented 1 month ago

The following header files reference an incorrect path and need to be modified to prevent build errors:

externals/glslang/SPIRV/Logger.h
externals/glslang/SPIRV/GlslangToSpv.h

Modify the following line in each:

FROM: #include "glslang/Include/visibility.h" TO: #include "../glslang/Include/visibility.h"

Shoegzer commented 1 month ago

Thanks for looking into this @arcady-lunarg. This is causing build problems with projects such as discussed here. I can open a PR for the fix if it helps.

arcady-lunarg commented 1 month ago

The problem here is that the paths have to work both when the files are installed and when building glslang itself, changing the paths would break the installation use case, but we also want to support your use case here. I'm not sure why this hasn't come up with other downstream users of glslang such as Vulkan Validation Layers though.

Shoegzer commented 1 month ago

Thank you for the explanation. What then can be done in this case? I'm guessing other projects have yet to raise the issue as it has only been a month or so since the change, it doesn't affect all use cases, and so it may have yet to be discovered and reported.