Closed fbarchard closed 8 years ago
Thanks fbarchard... I have a pending PR #380 for some texture sampling work, and folded your warning fixes above into that.
(I added it to that PR because it's touching the same lines of code for other reasons anyway.)
[834/2757] CXX obj/dreamos/external/glslang/glslang/hlslParseables.o ../../../../../../dreamos/external/glslang/hlsl/hlslParseables.cpp: In function 'glslang::TString& {anonymous}::AppendTypeName(glslang::TString&, const char, const char, int, int)': ../../../../../../dreamos/external/glslang/hlsl/hlslParseables.cpp:112:48: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if ((argOrder == 'V' || *argOrder == 'M') && (dim0 < 1 || dim0 > 4) || ^ ../../../../../../dreamos/external/glslang/hlsl/hlslParseables.cpp: In function 'bool {anonymous}::IsValidGlsl(const char, char, char, char, char, int, int, int, int)': ../../../../../../dreamos/external/glslang/hlsl/hlslParseables.cpp:148:15: warning: suggest parentheses around '&&' within '||' [-Wparentheses] if (isMat && (argType == 'I' || argType == 'U' || argType == 'B') || ^ At global scope:
The patch below adds parentheses and removes trailing spaces: