search

KhronosGroup / gltf-asset-auditor

Check glTF file attributes against commerce application use case requirements
Apache License 2.0
20 stars 3 forks source link

NPM repo of gltf-asset-auditor is not consistent with Git source #5

Open PritishSehzpaul opened 1 year ago

PritishSehzpaul commented 1 year ago

What

My team and I are working to integrate gltf-asset-auditor into our internal tool. We installed the npm module from https://www.npmjs.com/package/@khronosgroup/gltf-asset-auditor/v/1.0.1 but kept on getting issues with 'KHR_draco_mesh_compression' plugin in BabylonJS while loading glbs in @khronosgroup/gltf-asset-auditor\web-example.

On further analysis, I found that if we build @khronosgroup/gltf-asset-auditor from Github repo which does not contain 'KHR_draco_mesh_compression' in Line 463: await SceneLoader.AppendAsync('', glb.getBase64String(), this.scene, () => { }, 'KHR_draco_mesh_compression');, import and run that in web-example the code works perfectly.

On analyzing the node module, I saw that it contains 'KHR_draco_mesh_compression' in version 1.0.1 and not in 1.0.0 and the Github code does not. Node Module -

image

Github Source Code

image

Solution

@MikeFesta Can you please push a new version to npm repository without 'KHR_draco_mesh_compression' in SceneLoader.AppendAsync()?

PS: Thank you for building this respository. Great work!

MikeFesta commented 1 year ago

Thank you for that detailed analysis!

I think what happened is that I was testing fixes for the Draco compression bug after pushing to github and forgot to stash those changes when publishing to npm.

I just updated npm to version 1.0.2, which should be good to go. I'll keep the issue open for a few more days just in case.

PritishSehzpaul commented 1 year ago

Another suggestion I want to make is to tag the versions in git as and when they are released to npm. It would really help with following up on which code is live.