search

KhunakornP / A-plus-management

Productivity and task manager for students and academics alike.
Apache License 2.0
2 stars 0 forks source link

Feature/authentication user info #63

Open KhunakornP opened 1 day ago

KhunakornP commented 1 day ago

Extended the User class to include more information. The reason for the new models is for SRP principle since the User class should only concern about Authentication and not store user data.

codecov[bot] commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Files with missing lines Coverage Δ
manager/models.py 97.05% <100.00%> (+0.63%) :arrow_up:
manager/views.py 95.80% <100.00%> (+0.21%) :arrow_up:
KhunakornP commented 1 day ago

Somehow the ruff path on my main pc is wrong. I will lint the code later. For now please check out the code.

KhunakornP commented 17 hours ago

I have updated the code so that all Users are Students by default upon User creation for simplicity incase the user disconnects mid account creation (Users can change it later.). I have also updated the tests to reflect the change.

KhunakornP commented 17 hours ago

Also, do you think we should update the models to track which User created it before or after we remodel our backend to use REST API? I will be doing it in a separate branch but I am asking this so that I can prioritize my work correctly.

KhunakornP commented 17 hours ago

SIDE NOTE: expect the docs/config-google-oauth-instructions branch to be finished by tonight. Or do you think linking a wiki page in readme is better?

BioB3 commented 16 hours ago

Putting it as a new file should be better, you could link to it in the installation.md or readme

KhunakornP commented 15 hours ago

Alright, but please dont forget to review the pull request.