search

KiCad / Crystals.pretty

Crystal footprints
4 stars 23 forks source link

Add footprint for 2012 (2.0x1.2mm) crystal #16

Closed dingari closed 7 years ago

dingari commented 7 years ago

Introduce a 2.0x1.2mm 2 pad crystal oscillator footprint.

SchrodingersGat commented 7 years ago

Hi @dingari thanks for your contribution.

There are a few small things to address here, I would first point you to the KiCad Library Utils - these are a set of python scripts which will help you to quickly ensure conformance to the KLC.

In this case, I ran the following command:

python check_kicad_mod.py Crystal_SMD_2012_2Pads.kicad_mod -vv
checking module: Crystal_SMD_2012_2Pads
  Violating Rule 10.5
    Attributes is set to the appropriate value, see tooltip for more information.
  Violating Rule 6.3
    For through-hole components, footprint anchor is set on pad 1.
  Violating Rule 6.5
    Silkscreen is not superposed to pads, its outline is completely visible after board assembly, uses
    0.12mm line width and provides a reference mark for pin 1. (IPC-7351C).

10.5

This is a surface mount device, so you must set the Normal+Insert attribute (see below) smd

6.3

Fixing 10.5 will make this error go away

6.5

a) Reduce the line length of the silkscreen so it's not overlapping the pads b) Increase the line width of the F.Fab lines to 0.12mm

dingari commented 7 years ago

Hi, I believe I've fixed everything you mentioned.

Thanks for pointing out the python utils. I've run the check on the new footprint and it found no issues :)

SchrodingersGat commented 7 years ago

Looks good, thanks :)