updated library to meet KLC requirements and added several crystals/resonators

KiCad / Crystals.pretty

Crystal footprints

4 stars 23 forks source link

Closed jkriege2 closed 7 years ago

jkriege2 commented 7 years ago

based on scripts: https://github.com/pointhi/kicad-footprint-generator/pull/17
PR to rename 3D models and modify FPFilters: https://github.com/KiCad/kicad-library/pull/868
fixed all KLC issues (all footprints check out with new script versions!)
added many packages and different styles for packages
support existing 3d models

Screenshots show most (but not all variants!) of the new/updated footprints: c_tht1 c_tht2

crystal_all crystal_silk crystal_smd c_tht

SchrodingersGat commented 7 years ago

@jkriege2 this is a huge effort! Well done.

I would like to see some consistency with regard to naming convention.

The package size is currently designated as (e.g.)

I would suggest simply using (e.g.) _5.0x3.2mm without any extra words e.g. "package".

Also, sometimes you specify pin-count before package size, and sometimes after. Please use the same convention for all!

Great work otherwise :)

jkriege2 commented 7 years ago

OK, the names are more consistent now:

all SMD-footrpints use the for -**P**pin_**W**x**h**mm
THT footprints have either non sizes (standard packages, as e.g. HC49), or use a combination of the forms _w**W**mm _h**H**mm _d**D**mm _l**L**mm. This is necessary to accomodate the different measure of a (generally) not-rectangular package ... e.g. for round it would not be really clear whether 3x10mm is 3mm diameter and 10mm length, or vice-versa ...

Anything else?

Best, JAN

PS: 3D packages have been renamed and some more round 3D models were added (see https://github.com/KiCad/kicad-library/pull/868)

jkriege2 commented 7 years ago

Hi!

if you have time: please also review these, as they are connected (Oscillators, but use the same scripts!):

Best & Thanks, JAN

SchrodingersGat commented 7 years ago

Fantastic work once again.

Browsing through these I see a couple of 3D models that are misalinged:

crystal_hc33_u_vertical

crystal_smd_5032_4pin_5 0x3 2mm

Apart from that it looks very good.

jkriege2 commented 7 years ago

Hi!

I updated the footprints again and fixed those issues (also by adding new 3D models, see: https://github.com/KiCad/kicad-library/pull/868)

Ready to merge?

cu JAN

2017-01-12 15_21_51-3d viewer 2017-01-12 15_24_08-3d viewer

SchrodingersGat commented 7 years ago

Yep I think we are good to go. Fantastic :)