search

KiCad / Housings_SSOP.pretty

Shrink Small Outline Package footprints
5 stars 31 forks source link

Fixed a couple of KLC violations for SSOP footprints #12

Closed SchrodingersGat closed 8 years ago

SchrodingersGat commented 8 years ago

Fixes KLC 6.4 fot TSSOP-44 Fixes KLC 10.4 for MSOP-16

SchrodingersGat commented 8 years ago

bump

SchrodingersGat commented 8 years ago

@pointhi @diggit @ashtonchase anyone want to check this one out? It's been here for a while now...

SchrodingersGat commented 8 years ago

All package outlines have now been added to the F.Fab layer

SchrodingersGat commented 8 years ago

Fixed pin-1 silkscreen indicator as per https://github.com/KiCad/Housings_SSOP.pretty/issues/15

pointhi commented 8 years ago

as said in another PR before, please add pin 1 markers on the F.Fab layer.

CarlPoirier commented 8 years ago

This chould be a good example: image

Besides that, it's awesome!

SchrodingersGat commented 8 years ago

@CarlPoirier do you want the bevelled edge or happy with the circle?

CarlPoirier commented 8 years ago

I prefer the bevelled edge. It looks more streamlined to me.

SchrodingersGat commented 8 years ago

Ok I shall revert the most recent commit and update. We really need to be putting all these little conventions together into a more detailed document to outline requirements for "good" footprints.

SchrodingersGat commented 8 years ago

Any preferences between the following two examples @CarlPoirier or @pointhi ? :)

Option A a

Option B b

CarlPoirier commented 8 years ago

I do like the first one as we still get to see the real shape!

pointhi commented 8 years ago

I agree with @CarlPoirier, the first one

CarlPoirier commented 8 years ago

Oliver, wait before proceeding. We are in discussion on the IRC channel. Join us if you wish!

CarlPoirier commented 8 years ago

Oliver, we're onto something. Our suggestion is to use the same pin one marker as on the actual chip.This along with the outline would become a new KLC rule and apply to all footprints. What do you think?

Edit: Thank you for the few iterations you did and sorry for generating more work for your pull request.

SchrodingersGat commented 8 years ago

Our suggestion is to use the same pin one marker as on the actual chip.

So does this mean we are back to the small circle in the top-left corner? I'm happy with this or with the Option A as shown above. If it's the small circle option we want to go with I can un-revert the commit and all is done!

SchrodingersGat commented 8 years ago

Also I was not even aware of the IRC channel! Have joined now so I'll hang out there in future when I'm working on KiCad stuff

CarlPoirier commented 8 years ago

Yeah that would be the circle.

SchrodingersGat commented 8 years ago

Ok, then no work needed on this PR! LMK if you need any more changes before accepting.

CarlPoirier commented 8 years ago

Thank you Oliver, this is a great contribution.