KiCad / Housings_SSOP.pretty

Shrink Small Outline Package footprints
5 stars 31 forks source link

Add TSOP-I-48 12x18.4 mm pitch 0.5 mm #19

Closed piotr-wiszowaty closed 7 years ago

SchrodingersGat commented 7 years ago

Hi @piotr-wiszowaty can you please add the package shape to the F.Fab layer as per the other parts (with a 1mm bevel for pin-1 indication as per IPC)

untitled

Regards, Oliver

piotr-wiszowaty commented 7 years ago

Done.

On 12/24/2016 12:49 AM, Oliver wrote:

Hi @piotr-wiszowaty https://github.com/piotr-wiszowaty can you please add the package shape to the F.Fab layer as per the other parts (with a 1mm bevel for pin-1 indication as per IPC)

untitled https://cloud.githubusercontent.com/assets/10080325/21464002/96ea15d2-c9c6-11e6-98b9-c81ff77a306d.png

Regards, Oliver

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KiCad/Housings_SSOP.pretty/pull/19#issuecomment-269057769, or mute the thread https://github.com/notifications/unsubscribe-auth/AFAHEG98rP83dyRmNMlUu5iaLfD8_rHLks5rLF34gaJpZM4LU9KJ.

jkriege2 commented 7 years ago

Please also change silkscreen width to 0.12mm (update in KLCs)

Best, JAN

jkriege2 commented 7 years ago

Also: The pin-numbering is wrong on the rhs. It should start at the BOTTOM with 25 and end at the TOP with 48 (see DS p. 9)!

Otherwise: NICE WORK!

Best, JAN

piotr-wiszowaty commented 7 years ago

Done. But check_kicad_mod.py complains about this.

On 12/24/2016 03:40 PM, Jan W. Krieger wrote:

Please also change silkscreen width to 0.12mm (update in KLCs)

Best, JAN

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KiCad/Housings_SSOP.pretty/pull/19#issuecomment-269086962, or mute the thread https://github.com/notifications/unsubscribe-auth/AFAHEL0Ng7Hk8Iz6hJqY6WU5U29AE0gRks5rLS7dgaJpZM4LU9KJ.

piotr-wiszowaty commented 7 years ago

Done.

On 12/24/2016 03:42 PM, Jan W. Krieger wrote:

Also: The pin-numbering is wrong on the rhs. It should start at the BOTTOM with 25 and end at the TOP with 48 (see DS p. 9)!

Otherwise: NICE WORK!

Best, JAN

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KiCad/Housings_SSOP.pretty/pull/19#issuecomment-269087043, or mute the thread https://github.com/notifications/unsubscribe-auth/AFAHEIYcWcz_RVljFCwzyfZppYcOE1f4ks5rLS9ugaJpZM4LU9KJ.

jkriege2 commented 7 years ago
checking module: TSOP-I-48_12x18.4mm-Pitch0.5mm
  Violating Rule 10.1
    Footprint name must match its filename. (.kicad_mod files).
  Violating Rule 6.9
    Value and reference have a height of 1mm.

please ensure that you also rename the footprint name IN the file, not just the filename. Also please fix the KLC6.9 violation!

Thanks, JAN

piotr-wiszowaty commented 7 years ago

Name fixed. The height is set to 1 mm. When I set the thickness back to 0.15 mm (without changing anything else) the 6.9 violation disappears. So I am somewhat at a loss here.

On 12/25/2016 03:19 PM, Jan W. Krieger wrote:

|checking module: TSOP-I-48_12x18.4mm-Pitch0.5mm Violating Rule 10.1 Footprint name must match its filename. (.kicad_mod files). Violating Rule 6.9 Value and reference have a height of 1mm. |

please ensure that you also rename the footprint name IN the file, not just the filename. Also please fix the KLC6.9 violation!

Thanks, JAN

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KiCad/Housings_SSOP.pretty/pull/19#issuecomment-269124567, or mute the thread https://github.com/notifications/unsubscribe-auth/AFAHELzkIIzOcpSK-YLElvWXy_ngCwUsks5rLnt-gaJpZM4LU9KJ.

jkriege2 commented 7 years ago

Am 25.12.2016 um 21:37 schrieb Piotr Wiszowaty:

Name fixed. The height is set to 1 mm. When I set the thickness back to 0.15 mm (without changing anything else) the 6.9 violation disappears. So I am somewhat at a loss here.

The 0.12mm were introduced into the check-script a few weeks ago ... maybe an update of the script helps?

piotr-wiszowaty commented 7 years ago

I've just merged it - check result is the same. What am I missing?

$ check_kicad_mod.py -v TSOP-I-48_12x18.4mm_Pitch0.5mm.kicad_mod 
checking module: TSOP-I-48_12x18.4mm_Pitch0.5mm
  Violating Rule 6.9
    Value and reference have a height of 1mm.

tsopi48_1mm

jkriege2 commented 7 years ago

I think that's a bug in the script ... I tried to use the --fix option of thze script, which basically does 2 things: 2016-12-26 11_35_41-tsop-i-48_12x18 4mm_pitch0 5mm kicad_mod_ working tree - tortoisegitmerge

Only changing the linewidth was enough to cause the script to see the footprint as OK.

So I'll merge it in your form, as I think that's all correct. Could you please make a PR or add a bug to the script?

THanks, JAN