Closed Shackmeister closed 7 years ago
Also please add "%R" on all the footprints you have touched and bring them up to KLC2.0
@SchrodingersGat pretty sure I'm only adding 3d settings/paths (except for one where I'm changing the the offset on one axis from 0.02 to 0) Not sure what you mean by adding %R
If that's the case then it should be ok to merge.
The Travis scripts show you where the errors are. The SSOP footprints are violating KLC 7.4 as they do not have a second RefDes on the F.Fab layer.
@SchrodingersGat that is the case. should ${KISYS3DMOD}/ be added to the 3d path?
@Shackmeister are you using nightly or stable build? I am interested to know if the ${KISYS3DMOD} prefix causes any issue with stable build.
Im running stable and ${KISYS3DMOD} seems to work fine
I noticed the footprints having paranthesis in the name needs "" around the 3d path.. I guess paranthesis doesnt comply with KLC
can you explain how and where the %R should be added? then Ill fix it
and how should the MSOP-16(12)-1EP_3x4mm_Pitch0.5mm etc be renamed?
This is a second copy of the RefDes that needs to go on the F.Fab
layer at the center of the footprint (location 0,0, generally). To add this, place a text item at this location with the text value %R
.
IPC-7351C has a provision for footprints (land patterns) that have missing pins:
It should be named MSOP-12-16_
where 12
is the number of used pins and 16
is the total pin count (including skipped pins).
Does this make sense?
@SchrodingersGat I think thats about it from my side :) perhaps you consider to let Travis remove "-VIA" and "_Handsoldering" from the filename when comparing the 3d model path and filename (if it doesnt comply in first try)
Thanks for your work :)
@Shackmeister please notify me when the 3D models are ready to merge. I don't want to merge this PR until that is the case otherwise users will have broken 3D models in the interim.
Thanks