KiCad / kicad-footprints

Official KiCad Footprint Libraries for Kicad version 5
https://kicad.github.io/footprints
Other
617 stars 714 forks source link

Mean Well IRM-03 wrong footprints, maybe more due to docs #1320

Closed EngiBob closed 5 years ago

EngiBob commented 5 years ago

Hi,

The main problem is IRMs docs show things from different bottom view angles/rotations.

If you pull up the Kicad footprint Converter_ACDC_MeanWell_IRM-03-xx_THT it exactly mirrors the docs at https://www.meanwell.com/Upload/PDF/IRM-03/IRM-03-SPEC.PDF

If you look at an actual picture of the IRM-03 series you can see the mechanical drawings are actually upside down on the document (not all models are upside down, some are rotated around the y axis not z axis):

download

I just did a project using 3 modules, IRM-03, IRM-10, and IRM-15 class. There is no 15 in Kicad so I did my own with the help of product pictures (it is upside down too), IRM-10 is OK it looks like, and I'm doing IRM-03 right now... I've done two other projects with modules I can't remember at the moment and one of them I even swapped my output +/- and fried a test board due to the docs all being different. Where I can send the ones I've done for possible inclusion?

EngiBob commented 5 years ago

Also an error in the spacing, the Kicad footprint has 7.18 instead of 7.78.

EngiBob commented 5 years ago

I redid the library version of IRM-03, except for the position of the triangle for neutral. I also added the holes (for ventilation?).

https://gist.github.com/EngiBob/ddb95417a3fb4fbaaf60a70efe0b4cd3

Will have a board back in a couple weeks to try it out.

EngiBob commented 5 years ago

They soldered up my board without any issues, got them back today and my version of the footprint works.

antoniovazquezblanco commented 5 years ago

@EngiBob Could you please send a pull request to fix the issues in the official lib? It would be of great value to us.

evanshultz commented 5 years ago

@EngiBob Sorry to hear about your troubles and that there were due to errors in our library.

Since there's a lot going on above let me work through all the MeanWell IRM series we have now.

Since this report is specifically about IRM-03, and the official library has no symbol, unfortunately it seems the symbol creation didn't involve validating the footprint.

Proposed changes:

  1. Flip IRM-03 THT footprint and fix dimensional error of 17.18mm to 17.78mm.
  2. Add IRM-03, IRM-05, and IRM-10 THT symbols to avoid the need for external symbols which could cause problems for KiCad users. Match the existing footprint pinouts to avoid anything already in the library getting changed.

Other notes:

evanshultz commented 5 years ago

@EngiBob Thanks for this report. I've submitted 2 PRs, shown above, that will fix this issue. If you'd like to verify my fixes are correct that would be welcome. Thank you.