search

KiCad / kicad-footprints

Official KiCad Footprint Libraries for Kicad version 5
https://kicad.github.io/footprints
Other
621 stars 712 forks source link

KBPC package #2311

Closed aris-kimi closed 4 years ago

aris-kimi commented 4 years ago

Hi everyone,

About existing "Diode_Bridge_28.6x28.6x7.3mm_P18.0mm_P11.6mm" package. It is named with width, length, height and pitch, but according to it's datasheet: https://diotec.com/tl_files/diotec/files/pdf/datasheets/kbpc1500fw.pdf i think it should be renamed.

My confusion is, i am about to PR all KBPC symbols from this link: https://www.diodemodule.com/bridge-rectifier/kbpc/ as two symbols with -T and -W with alliases, but this datasheet: https://www.diodemodule.com/bridge-rectifier/kbpc/kbpc50005t.pdf suggests that footprint name should be KBPC_T and KBPC_W, how should i proceed?

I think that the first footprint "Diode_Bridge_28.6x28.6x7.3mm_P18.0mm_P11.6mm"

should be be renamed to something like "Diode_Bridge_KBPC_W_Unmount" or "*_No_Mountpoint" with description "Single phase, bridge rectifier, case KBPC_W(WP)"

And my additions should be named like "Diode_Bridge_KBPC_W_Mount" or "*_Mountpoint" with description "Single phase, bridge rectifier, case KBPC_W(WP)"

and "Diode_Bridge_KBPC_T_Mount" or "*_Mountpoint" with description "Single phase, bridge rectifier, case KBPC_T(FP)"

I think dimensions should be omitted.

Also, i couldn't find any symbol that uses the existing footprint "Diode_Bridge_28.6x28.6x7.3mm_P18.0mm_P11.6mm"..

Plus, with the same logic i can also add "Diode_Bridge_KBPC_T_Unmount"...

kbpc

kbpc_ft

aris-kimi commented 4 years ago

Hi all, i ~will upload~ have uploaded 4 footprints: Please confirm naming. Only one is currently active(and kind of updated) but i want to start working with them in order to finish with complete symbol if possible.

Diode_Bridge_GeneSiC_Semiconductor_KBPC_T_Mount https://github.com/KiCad/kicad-footprints/pull/2337 Diode_Bridge_GeneSiC_Semiconductor_KBPC_W_Mount https://github.com/KiCad/kicad-footprints/pull/2340 Diode_Bridge_GeneSiC_Semiconductor_KBPC_T_NoMount https://github.com/KiCad/kicad-footprints/pull/2339 Diode_Bridge_GeneSiC_Semiconductor_KBPC_W_NoMount https://github.com/KiCad/kicad-footprints/pull/2341

or

Diode_Bridge_GeneSiC_Semiconductor_KBPC_T_Heatsink Diode_Bridge_GeneSiC_Semiconductor_KBPC_W_Heatsink Diode_Bridge_GeneSiC_Semiconductor_KBPC_T_NoHeatsink Diode_Bridge_GeneSiC_Semiconductor_KBPC_W_NoHeatsink

~one by one in different PRs. Ithink this will close this issue when all merged..~

aris-kimi commented 4 years ago

Removed manufacturer name from ft, closing this issue now, also two PRs from above..